[Do Not Merge]Test close after proxy header #19883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
|
/wait |
soulxu
changed the title
soulxu
commented
Feb 9, 2022
| @@ -338,6 +338,12 @@ TEST_P(ProxyProtoFilterChainMatchIntegrationTest, MatchDirectSourceAndSource) { | |||
| testing::HasSubstr("directsource_localhost_and_source_1.2.3.0/24 -")); | |||
| } | |||
|
|
|||
| TEST_P(ProxyProtoFilterChainMatchIntegrationTest, CloseAfterProxyProtocol) { | |||
| send("PROXY TCP4 1.2.3.4 254.254.254.254 12345 1234", true); | |||
There was a problem hiding this comment.
Using the end_stream flag to end the connection before sending the full proxy header. @ggreenway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: He Jie Xu hejie.xu@intel.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]